Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map genre/form label if GND-ID is available in 655 but no label #2082

Open
maipet opened this issue Oct 15, 2024 · 1 comment
Open

Map genre/form label if GND-ID is available in 655 but no label #2082

maipet opened this issue Oct 15, 2024 · 1 comment
Assignees
@maipet
Labels
Transformation

Comments

@maipet
Copy link
Contributor

maipet commented Oct 15, 2024

Map the label from https://github.com/hbz/lobid-resources/blob/5c4dc57859a49592c1f519fb2057f6c25ea288f9/src/main/resources/alma/maps/formangabe.tsv if GND-ID exists but label $a is empty.
At the moment the subfield $a must exist if a GND-ID is given
E.g. 991030115479706476
@maipet maipet self-assigned this Oct 15, 2024
maipet added a commit that referenced this issue Nov 5, 2024
@maipet
Add lookup for Formangabe-Label if GND-ID exists #2082
1fed759
maipet added a commit that referenced this issue Nov 5, 2024
@maipet
Add test (#2082)
b68b583 
Complements bb77c45.
@maipet maipet mentioned this issue Nov 5, 2024
Closed
maipet added a commit that referenced this issue Nov 5, 2024
@maipet
Add test record (#2082)
85adc7a
maipet added a commit that referenced this issue Nov 5, 2024
@maipet
Add new marc testrecord (#2082)
b91a27e
maipet added a commit that referenced this issue Nov 5, 2024
@maipet
Add lookup for Formangabe-Label if GND-ID exists (#2082)
f1e8798
maipet added a commit that referenced this issue Nov 5, 2024
@maipet
Add test (#2082)
194e721 
Complements b91a27e.
@maipet maipet mentioned this issue Nov 5, 2024
Merged
@dr0i
Copy link
Member

dr0i commented Nov 7, 2024

Deployed next Monday. To be checked then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maipet maipet

Labels
Transformation
Projects
lobid-resources
Status: Review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dr0i @maipet