-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate context related info from plain label related info in context-labels.json and labels.json #1907
Comments
I am pretty sure that this will just gain us more redundancy and pitfalls. |
TobiasNx
added a commit
that referenced
this issue
Sep 26, 2023
Labels are provided by the rpb ttl-files in the submodule.
TobiasNx
added a commit
that referenced
this issue
Sep 26, 2023
I created a PR for cleaning up context-labels.json and labels.json without renaming them. |
Merged
Merged
PR is merged. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The ettiket-maker does two things:
It uses all files in
src/main/resources/labels
:But only those with "name" are added to the context while those with only "label" are not.
Some of the values in the context are also in
labels.json
.I suggest to consistently use
context-labels.json
for properties and classes that are added to the context.While entity labels are only added in labels. Perhaps rename
labels.json
intoentity-labels.json
.The text was updated successfully, but these errors were encountered: