Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate context related info from plain label related info in context-labels.json and labels.json #1907

Closed
TobiasNx opened this issue Sep 25, 2023 · 3 comments · Fixed by #1912 or #1910

Comments

@TobiasNx
Copy link
Contributor

The ettiket-maker does two things:

  1. add labels were labels are missing
  2. creates the context for json-ld

It uses all files in src/main/resources/labels:

But only those with "name" are added to the context while those with only "label" are not.
Some of the values in the context are also in labels.json.
I suggest to consistently use context-labels.json for properties and classes that are added to the context.
While entity labels are only added in labels. Perhaps rename labels.json into entity-labels.json.

@dr0i
Copy link
Member

dr0i commented Sep 25, 2023

I am pretty sure that this will just gain us more redundancy and pitfalls.
Read #899 (comment) .
Update https://github.com/hbz/lobid-resources/wiki/How-context.jsonld-is-generated.

TobiasNx added a commit that referenced this issue Sep 26, 2023
Labels are provided by the rpb ttl-files in the submodule.
@TobiasNx
Copy link
Contributor Author

I created a PR for cleaning up context-labels.json and labels.json without renaming them.
We then have only one file for context related classes and properties.

@dr0i
Copy link
Member

dr0i commented Sep 28, 2023

PR is merged. Closing.

@dr0i dr0i closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants