Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classes for persons in data and UI #310

Open
acka47 opened this issue Apr 29, 2022 · 0 comments
Open

Fix classes for persons in data and UI #310

acka47 opened this issue Apr 29, 2022 · 0 comments
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Apr 29, 2022

Currently, we display "Individualisierte Person", "Regierender Fürst oder Mitglied eines regierenden Fürstenhauses"/RoyalOrMemberOfARoyalHouse, "Literarische oder Sagengestalt"/LiteraryOrLegendaryCharacter, "Sammelpseudonym"/CollectivePseudonym, "Götter"/Gods, "Geister"/Spirits as different sub-classes of "Person".

image

In fact, all of them are also of type DifferentiatedPerson/"Individualisierte Person". We should correct this.

Proposed approach

The easiest way which is also consistent with the other super types (e.g. "CorporateBody") would be to remove the type DifferentiatedPerson completely from the data.

Pro arguments for this approach

  • There exists no difference between Person and DifferentiatedPerson anymore in GND data as UndifferentiatedPerson as the other type of Person was removed.
  • In the UI we would then have Person as top class and below it the existing specified types that would not match up to the number of Persons, just like for the other top classes CorporateBody, ConferenceOrEvent etc.

image

Contra argument

  • If applications rely on the type DifferentiatedPerson they would be broken by this change.

(This issue was reported by Johannes Bracht during a joint meeting of the lobid team (represented by @fsteeg and @acka47) and GND4C project members.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants