Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic temporaryName property instead of specific ones #227

Open
acka47 opened this issue Sep 13, 2019 · 7 comments
Open

Use generic temporaryName property instead of specific ones #227

acka47 opened this issue Sep 13, 2019 · 7 comments
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Sep 13, 2019

As with preferredName, we should only use temporaryName in lobid-gnd data for all these properties: temporaryName, temporaryNameOfTheConferenceOrEvent, temporaryNameOfTheCorporateBody, temporaryNameOfThePlaceOrGeographicName.

@fsteeg
Copy link
Member

fsteeg commented Sep 13, 2019

That's a good idea too, but what we discussed was about abbreviatedNameForThe*.

@acka47
Copy link
Contributor Author

acka47 commented Sep 13, 2019

That's a good idea too, but what we discussed was about abbreviatedNameForThe*.

Yes, but we can already implement this as a generic property exists. For abbreviatedNameForThe* I will first open an issue at DNB to add the generic property in the first place.

@fsteeg
Copy link
Member

fsteeg commented Oct 7, 2022

After looking at this, I now think #229, like this here, is actually about using the generic property (abbreviatedName there, temporaryName here), and filling it with values that in the DNB data are stored in the specific fields. Given that we have some unification with the DNB data on the horizon, and this has not been driven by a concrete user request, I think we should not invest the time to implement this right now.

@acka47
Copy link
Contributor Author

acka47 commented Oct 10, 2022

Ok. Then we can close this issue for now?

@acka47 acka47 assigned fsteeg and unassigned acka47 Oct 10, 2022
@acka47
Copy link
Contributor Author

acka47 commented Oct 10, 2022

Shouldn't we include temporaryName, temporaryNameOfTheConferenceOrEvent, temporaryNameOfTheCorporateBody, temporaryNameOfThePlaceOrGeographicName for reconciliation queries then? Or is this already the case. Doesn't seem so when looking at #228.

@fsteeg
Copy link
Member

fsteeg commented Oct 10, 2022

Yes, good catch! We only had temporaryName (which isn't used in the data). Added the specific ones in bd52135.

@acka47
Copy link
Contributor Author

acka47 commented Oct 11, 2022

As discussed offline, we aim at the consistent approach for all name properties, i.e. using *Name only and getting rid of specific versions like *NameOfTheCorporateBody but will not implement this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants