Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change n in get_helix_waypoints does not work #7

Open
LTH14 opened this issue May 8, 2019 · 4 comments
Open

Change n in get_helix_waypoints does not work #7

LTH14 opened this issue May 8, 2019 · 4 comments

Comments

@LTH14
Copy link

LTH14 commented May 8, 2019

Hi!
I got some problem in generating the waypoints using your simulator. The default script runs well, but when I change the number of waypoints in the runsim.py (waypoints = trajGen3D.get_helix_waypoints(0, 10) for example), the quadrator does not follow the desired path and flies away. Any idea on how to solve this? Thanks a lot!

@LTH14
Copy link
Author

LTH14 commented May 8, 2019

BTW, previously I got issues on the numpy version. Now I am using numpy 1.16.0, scipy 1.2.1, python 3.7.0. Possibly it is because of python version or package version? Which version are you using? Thanks!

@juanmed
Copy link
Collaborator

juanmed commented May 12, 2019

Hello @LTH14

I dont think the python version you are using is an issue. The issue you are describing happens with the PID controller developed by the author. I have not dedicated time to analyze it so I cannot provide and answer on how to solve it.

In the meantime, you can try my fork where I have further developed the simulator (eliminated some problems with heading calculation, added some controllers, added graphing features...). I tried your case (10 waypoints) and did not see any strange behaviour with the PID controller.

I was supposed to be pushing changes to the original author's repo but could not do it for several reasons.

I hope this helps!

@lmmedino
Copy link

lmmedino commented May 3, 2020

Hi, I tried using your fork, but when I run the LQR controller it does not track the trajectory well, is there anything that needs to change for LQR to work?

@lmmedino
Copy link

@juanmed just following up on this, I tried using your fork, but when I run the LQR controller it does not track the trajectory well, is there anything that needs to change for LQR to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants