-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deno info to search for imports #100
base: master
Are you sure you want to change the base?
Conversation
I noticed this requires --allow-run=deno (also known as -A) |
I also noticed the tests are way slower |
|
Thanks @iuioiua I updated the code with deno graph The tests are not slow anymore, and no new permissions is needed with deno graph I'm not 100 % confident of the code, but it seems to work and pass tests This PR implements the search for the import which gives precise location of the urls but this info is not being used currently, maybe in a future pr we can leverage that for url replacement instead of the current regex approach |
I just noticed that this pr make udd not work on import map anymore |
The problem is with bare specifier like $fresh, those don't get resolved But it seems like deno info can resolve bare specifiers, so I probably need to look how they do it |
deno_graph exposes |
fix #8
I left couple of notes
This implements the search, and the search gives precise location of the urls, maybe we can in the future use that for replacement.
The tests passes, I did not test more