-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer some type of distributable bundle #21
Comments
Hmm. My first intuition is that this seems kind of overkill for what is really a pretty simple project. Although, it does seem like it is slowly gravitating towards getting bigger and more complicated over time. |
I guess it's also worth noting that I don't know how popular this project actually is, and what most users want. Is your intuition that this is something that most people would want? |
After some discussion, I'm good with going for this. Obviously, showing up on the issues page means that it's something that at least some people want and there are definite benefits to making the player easier for people to use. :) |
Was just thinking about this, and I think a good first step (or compromise) would be to introduce a basic module import system like AMD. So the
This would help reduce exposed globals, improve circular dependency issues. Could use something like Require.js, but it seems like overkill for this project atm. Examples of a simple AMD solution I was thinking: |
Though I'd be hesitant to introduce a Node + npm + Browserify stack to such a simple, straightforward project, it might be the best step forward to allow people to integrate the eleVR Web Player in their projects with minimal friction.
There could be
package.json
), which would make versioning easier (and shrink the codebase in this repo).dist/
directory, which contains the combined JS bundles, concatenated and all. every time a commit is made or a PR is merged, thedist/
directory isn't touched. only when a major version (i.e., a tag) is made is there a new version of thedist/
files created. lots of projects have likedist/bundle.js
anddist/bundle.min.js
. it's easier for folks to just grab these files and get up and running. (and even better would be to have some service like cdnjs.com actually host the files too, so folks can just link directly to the scripts.) a good example of this practice that comes to mind: https://github.com/jakearchibald/es6-promiseThe text was updated successfully, but these errors were encountered: