Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why fork bisq? #15

Closed
goodboy opened this issue Apr 8, 2021 · 4 comments
Closed

Why fork bisq? #15

goodboy opened this issue Apr 8, 2021 · 4 comments
Labels
is:question Request of information

Comments

@goodboy
Copy link

goodboy commented Apr 8, 2021

Curious why you've decided to entirely fork bisq when they're already looking at adding this?

Relevant issue set:

I mean all the power to you but just seems like burning rubber on many roads.

@erciccione erciccione added the is:question Request of information label Apr 8, 2021
@erciccione
Copy link
Contributor

Please see in the readme: Why a new platform

they're already looking at adding this in bisq-network/bisq#5285

That proposal is definitely an improvement over the current situation, but requiring traders to own the entire amount in Bitcoin makes it unintuitive and way too demanding. I see the point behind it and i appreciate the effort, but it don't think would bring real benefits.

@goodboy
Copy link
Author

goodboy commented Apr 8, 2021

@erciccione I think it's good if you can justify the fork 💯 .

Probably good to let new viewers of this code base see where the potential improvements can be found as things progress 🏄🏼

@sethforprivacy
Copy link

It's also important to note that Monero integrations have been proposed, built, and rejected several times in the past, despite the vast majority of volume on Bisq being XMR/BTC:

bisq-network/bisq#1863
bisq-network/proposals#110
https://bisq.network/blog/cycle-6-results/
bisq-network/proposals#122

The latest attempt to add Monero to Bisq is already receiving pushback and requires 115% deposits in BTC to trade XMR against fiat, which is not only a massive UX hurdle, it doesn't improve the ability for users to trade solely fiat<>XMR without owning substantially more BTC first.

@erciccione
Copy link
Contributor

Closing this, as the question has been answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:question Request of information
Projects
None yet
Development

No branches or pull requests

3 participants