-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php 5.5 compatibility #4
Comments
I'll +1 the request for PHP 5.5 compatibility. However, Johan's fix doesn't seem to work for me. When I apply it, I get BibCite('$m[1]', 'LS1988') instead of a citation. |
changes in the file should be exactly as by @johanlofberg written:
(pmwiki 2.2.58 and newer, end 2013) |
Thanks I missed the lack of quotes, I've got it fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Any plans to make it php 5.5 compatible?
All you have to do with the markups is to is to use replace Markup with Markup_e, change /e to /, and replace '$1' with $m[1]
(requires pmwiki 2.2.58)
The text was updated successfully, but these errors were encountered: