Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending of the form does not work when the value of the buttons are in another language then German #5

Open
jankout opened this issue Nov 4, 2016 · 0 comments

Comments

@jankout
Copy link

jankout commented Nov 4, 2016

Hello,

unfortunately, when I send the form nothing happens when the button values are in English. When they are in German it works. Is there a language restriction for it? What can be the problem?

Update: I've found the section that causes the problem. In your files

  • ModuleHcMailchimpUnsubscribeForm.php
  • ModuleHcMailchimpSubscribeForm.php
  • ModuleHcMailchimpSubscribeFormShort.php

you use very restrict command

if (Input::post('submit') == "Senden")

If you want to use a language restriction, it would be better to use the restriction for each language separately. But I think it would be a lot of work.

I think this is not the right way when somebody use a multilingual website. It shouldn't be so restrict and it should be free from any language settings.

Could you improve it, please? Thank you.

@jankout jankout changed the title Sending of the form does not work Sending of the form does not work when the value of the buttons are in English Nov 4, 2016
@jankout jankout changed the title Sending of the form does not work when the value of the buttons are in English Sending of the form does not work when the value of the buttons are in another language then German Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant