You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First it checks if there are any undeprecated commitments; then it checks if any of those have a matching local ID. In this case there were 1) deprecated commitments and 2) commitments that were not deprecated & did not match the local ID.
We should reverse the order of the last two checks; that is, first check if there is a commitment with the matching local ID, then check if it’s already deprecated.
The text was updated successfully, but these errors were encountered:
This error message is misleading:
https://github.com/hathitrust/holdings-backend/blob/main/lib/shared_print/deprecation_record.rb#L79-L83
First it checks if there are any undeprecated commitments; then it checks if any of those have a matching local ID. In this case there were 1) deprecated commitments and 2) commitments that were not deprecated & did not match the local ID.
We should reverse the order of the last two checks; that is, first check if there is a commitment with the matching local ID, then check if it’s already deprecated.
The text was updated successfully, but these errors were encountered: