From f6e1d9c29439cb8723f3708c34cd75bc0681144a Mon Sep 17 00:00:00 2001 From: Daniel Harvey Date: Fri, 30 Aug 2024 15:12:22 +0100 Subject: [PATCH] Enable mutations v2 by default (#601) ### What Generated point mutations have been an opt-in feature for a while. Now we advertise them in the Postgres getting started docs, it's probably time to say they are generally available. This won't affect existing configurations (a missing value still means "no generated mutations please". ### How Change the default. --- changelog.md | 2 ++ crates/configuration/src/version5/mod.rs | 4 +--- ...ent_only_configure_initial_configuration_is_unchanged.snap | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/changelog.md b/changelog.md index f58e9daa..80426033 100644 --- a/changelog.md +++ b/changelog.md @@ -4,6 +4,8 @@ ### Added +- Enabled point mutations by default for newly generated configuration. + ### Changed ### Fixed diff --git a/crates/configuration/src/version5/mod.rs b/crates/configuration/src/version5/mod.rs index 9a3b9ad4..14e7d8e6 100644 --- a/crates/configuration/src/version5/mod.rs +++ b/crates/configuration/src/version5/mod.rs @@ -67,9 +67,7 @@ impl ParsedConfiguration { connection_settings: connection_settings::DatabaseConnectionSettings::empty(), metadata: metadata::Metadata::default(), introspection_options: options::IntrospectionOptions::default(), - // we'll change this to `Some(MutationsVersions::V1)` when we - // want to "release" this behaviour - mutations_version: None, + mutations_version: Some(metadata::mutations::MutationsVersion::V2), } } diff --git a/crates/tests/databases-tests/src/postgres/snapshots/databases_tests__postgres__cli_version5_tests__postgres_current_only_configure_initial_configuration_is_unchanged.snap b/crates/tests/databases-tests/src/postgres/snapshots/databases_tests__postgres__cli_version5_tests__postgres_current_only_configure_initial_configuration_is_unchanged.snap index a18a0087..36972aed 100644 --- a/crates/tests/databases-tests/src/postgres/snapshots/databases_tests__postgres__cli_version5_tests__postgres_current_only_configure_initial_configuration_is_unchanged.snap +++ b/crates/tests/databases-tests/src/postgres/snapshots/databases_tests__postgres__cli_version5_tests__postgres_current_only_configure_initial_configuration_is_unchanged.snap @@ -3123,5 +3123,5 @@ expression: default_configuration "varchar": "string" } }, - "mutationsVersion": null + "mutationsVersion": "v2" }