Deprioritise deprecated modules in Quick fix suggestions

[MatthewDaggitt]

Is your enhancement request related to a problem? Please describe.

When I have an out of scope error:

then the quick fix doesn't take into account whether a module is deprecated or not. For example, here Monad.Control.Error is the top hit in the list despite the fact that Monad.Control.Error is deprecated in favour of Monad.Control.Except.

This means I frequently end up importing the former instead of the latter and then having to change it.

Describe the solution you'd like

Deprecated modules should appear at the bottom of the suggestions list, and ideally should have some sort of visual indication that they are deprecated.

Describe alternatives you've considered

None.

Additional context

None.

[Anrock]

and ideally should have some sort of visual indication that they are deprecated.

LSP spec has this, actually. Either via deprecated CompletionItem.deprecated or the recommended way by putting CompletionItemTag.Deprecated into CompletionItem.tags list. I guess it should be trivial change if deprecation info is easily available from Haskell side of things in HLS.

Nevermind, I thought it was about completions.

[michaelpj]

Duplicate of #2415, I think?

[michaelpj]

Note that there's an unfinished PR here, if someone wants to pick it up: ;#2949