Code lens to display type signature for local bindings in where clauses

[July541]

Reminded by #2019 (comment), I think it would be great to have a configurable plugin to display a signature code lens for local bindings in where clauses.

Please let me know if there has more places need code lenses.

Edited: I'll try to pick bindings from RenamedSource, please let me know if there is a more efficient way. Should be TypeCheckedSource.

[michaelpj]

configurable

Configuration is bad! I say have it be enabled whenever the main type signature lens is.

[July541]

Configuration is bad! I say have it be enabled whenever the main type signature lens is.

Could you please explain why configuration is bad? Ideally I want to control everything displayed on my screen by category...

[michaelpj]

Because it means more things for users to think about, a bigger settings page, and more things for us to support. I think if we can, it's best only to introduce configuration in cases where there's a real split in what people want and people are annoyed if they don't get the one they want.

[July541]

So, we can implement this feature into ghcide?

[michaelpj]

I think that's reasonable. Especially since I'd hope the code is mostly there already!

[uhbif19]

Does not it already show type signatures?

[July541]

Does not it already show type signatures?

Yes, but it requires users hover on it, I'm going to display code lens directly like this:

[uhbif19]

@July541 Now I got it, I misunderstood that "code lens" is, I thought lens is a bubble.

That is cool. But why this issue is concerned only on where clauses? Should be cool to see this in let clauses too. Now I do not get them.

[July541]

I initially want to display sigs for let bindings by inlay hints, see #2938, but now I think it's not bad to show code lens too, maybe it is worth trying after #2966 :)

[michaelpj]

I think doing a code lens is good: code lenses fit better for places where you can put signatures on their own lines, which is probably better in general.