Skip to content

Commit 7d9d53e

Browse files
BodigrimMikolaj
authored andcommitted
Make lukko flag automatic and off by default
The lukko package (https://hackage.haskell.org/package/lukko) was meant to be a temporary workaround, and relevant improvements have been long accessible from base:GHC.IO.Handle.Lock. As suggested at haskellari/lukko#39 (comment), let's switch the default value of the lukko flag of cabal-install from True to False. Additionally, to be on the safe side, we make it an automatic one, so that if things go terribly wrong a Hackage revision could sort it back. The same change has been implemented for the hackage-security package sometime ago in haskell/hackage-security#322, and there seems to be no complaints.
1 parent df88415 commit 7d9d53e

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

cabal-install/cabal-install.cabal

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ Flag native-dns
3636

3737
Flag lukko
3838
description: Use @lukko@ for file-locking
39-
default: True
40-
manual: True
39+
default: False
40+
manual: False
4141

4242
flag git-rev
4343
description: include Git revision hash in version

changelog.d/pr-11003.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
synopsis: Make lukko flag automatic and off by default
3+
packages: [cabal-install]
4+
prs: 11003
5+
issues: 10724
6+
---
7+
8+
Make `lukko` flag automatic and off by default, using file locking facilities from `base:GHC.IO.Handle.Lock` and not from the `lukko` package. The change is not expected to affect anyone detrimentally, but one can set the flag on in their configuration to restore the previous behaviour.

0 commit comments

Comments
 (0)