cabal-install: dynExe+profExe requires prof+dyn

This commit updates the logic in cabal-install's 'elaborateInstallPlan'
function to ensure that we don't try to build a profiled dynamic
executable if the compiler doesn't support the profiling dynamic way.

This brings the logic in cabal-install in sync with the Cabal
'configureProfiling' function, which sets 'withDynExe' to false if the
user wants a profiled executable but prof+dyn is not supported by the
compiler.

Author: sheaf

Cabal/src/Distribution/Simple/Compiler.hs

@@ -509,11 +509,13 @@ profilingVanillaSupported comp = waySupported "p" comp
 
 -- | Is the compiler distributed with profiling dynamic libraries
 profilingDynamicSupported :: Compiler -> Maybe Bool
-profilingDynamicSupported comp =
-  -- Certainly not before this version, as it was not implemented yet.
-  if compilerVersion comp <= mkVersion [9, 11, 0]
-    then Just False
-    else waySupported "p_dyn" comp
+profilingDynamicSupported comp
+  | GHC <- compilerFlavor comp
+  -- Certainly not before 9.11, as prof+dyn was not implemented yet.
+  , compilerVersion comp <= mkVersion [9, 11, 0]
+  = Just False
+  | otherwise
+  = waySupported "p_dyn" comp
 
 -- | Either profiling dynamic is definitely supported or we don't know (so assume
 -- it is)

cabal-install/src/Distribution/Client/ProjectPlanning.hs

@@ -2280,9 +2280,13 @@ elaborateInstallPlan
                 , withSharedLib = canBuildSharedLibs && pkgid `Set.member` pkgsUseSharedLibrary
                 , withStaticLib = perPkgOptionFlag pkgid False packageConfigStaticLib
                 , withDynExe = perPkgOptionFlag pkgid False packageConfigDynExe
+                                 && (okProfDyn || not profExe)
+                                   -- We can't produce a dynamic executable if the user
+                                   -- wants to enable executable profiling but the
+                                   -- compiler doesn't support prof+dyn.
                 , withFullyStaticExe = perPkgOptionFlag pkgid False packageConfigFullyStaticExe
                 , withGHCiLib = perPkgOptionFlag pkgid False packageConfigGHCiLib -- TODO: [required feature] needs to default to enabled on windows still
-                , withProfExe = perPkgOptionFlag pkgid False packageConfigProf
+                , withProfExe = profExe
                 , withProfLib = canBuildProfilingLibs && pkgid `Set.member` pkgsUseProfilingLibrary
                 , withProfLibShared = canBuildProfilingSharedLibs && pkgid `Set.member` pkgsUseProfilingLibraryShared
                 , exeCoverage = perPkgOptionFlag pkgid False packageConfigCoverage
@@ -2297,6 +2301,8 @@ elaborateInstallPlan
                 , withProfLibDetail = elabProfExeDetail
                 , withProfExeDetail = elabProfLibDetail
                 }
+            okProfDyn = profilingDynamicSupportedOrUnknown compiler
+            profExe = perPkgOptionFlag pkgid False packageConfigProf
 
             ( elabProfExeDetail
               , elabProfLibDetail