Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Werror for source dependencies? #166

Open
thumphries opened this issue Mar 13, 2017 · 1 comment
Open

-Werror for source dependencies? #166

thumphries opened this issue Mar 13, 2017 · 1 comment

Comments

@thumphries
Copy link
Contributor

(more of a question than an issue)

Should warnings in source dependencies / subprojects be mafia errors?

As it stands, if a subproject and its source dependencies get out of sync, inexhaustive pattern matches can end up in production. Seems to me that the ownership boundary is usually the project rather than the package. @jystic

@erikd
Copy link
Contributor

erikd commented Mar 13, 2017

Should warnings in source dependencies / subprojects be mafia errors?

I don't think so, but I don't want to see them silenced either.

As it stands, if a subproject and its source dependencies get out of sync, inexhaustive pattern matches can end up in production.

Subprojects can have non-total functions or throw exceptions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants