Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up source dependency build artefacts #138

Open
thumphries opened this issue Sep 8, 2016 · 5 comments
Open

Clean up source dependency build artefacts #138

thumphries opened this issue Sep 8, 2016 · 5 comments

Comments

@thumphries
Copy link
Contributor

I have 22GB worth of build artefacts inside dist dirs in source dependencies. Seems like this would be easy to nuke inside mafia clean, i.e. remove lib/source-dep/dist for each source dep.

Any reason not to implement this? @jystic

@erikd-ambiata
Copy link
Contributor

mafia clean cleans the build artifacts from the current project (much like cabal clean does). I think making it also clean all the build artefacts for the required libraries would be a bad idea, especially for anything that uses amazonka.

However i would be 👍 on an extra command option like mafia clean --purge.

@jacobstanley
Copy link
Contributor

I think if you delete those directories it will corrupt your cache? need to verify that.

Ideally we should treat source dependencies the same as hackage ones and build a copy of the source in the global cache, that's the real fix I think.

@thumphries
Copy link
Contributor Author

I think if you delete those directories it will corrupt your cache?

That's... concerning. Why? Data files?

@thumphries
Copy link
Contributor Author

I think making it also clean all the build artefacts for the required libraries would be a bad idea, especially for anything that uses amazonka.

AFAIK you don't get any reuse out of those dist dirs, since they get dropped into the global cache and then symlinked back.

@jacobstanley
Copy link
Contributor

That's... concerning. Why? Data files?

Yeah it is, I'm not 100% on that, I just have my suspicions that's it could be a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants