Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esqueleto: Please relax upper bound on base package #65

Closed
erikd opened this issue Apr 20, 2016 · 5 comments
Closed

esqueleto: Please relax upper bound on base package #65

erikd opened this issue Apr 20, 2016 · 5 comments

Comments

@erikd
Copy link

erikd commented Apr 20, 2016

GHC 8.0 ships with base 4.9, but esqueleto currently requires base < 4.9. I have submitted a PR but so far that has gone un-answered : prowdsponsor/esqueleto#135

Esqueleto doesn't have a lot of other packages depending on it, but it really should compile with ghc-8.0 and all that is required is this tiny tweak.

@erikd
Copy link
Author

erikd commented Apr 20, 2016

I have compiled this with GHC 8.0 rc3 and run all the tests.

Esqueleto doesn't use template-haskell directly so there are no TH issues.

@cartazio
Copy link
Member

tested it on my post iavor ghc8.0 tip build, also works here, i'll bump the bound < 4.10, @erikd that what you want right? :)

@erikd
Copy link
Author

erikd commented Apr 20, 2016

Perfect!

@cartazio
Copy link
Member

bumped, also added it to matrix builder queue just to sanity check, closing for now :)

@erikd
Copy link
Author

erikd commented Apr 20, 2016

Thanks @cartazio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants