Panic in Terraform console command

[pcarles]

Terraform Version

Terraform v1.4.6
on linux_amd64

Terraform Configuration Files

No config files required

Debug Output

https://gist.github.com/pcarles/da14c26485822361018252868c66e62f

Expected Behavior

Terraform should exit gracefully

Actual Behavior

Terraform panic with a segfault

Steps to Reproduce

1. terraform console anywhere
2. Hit Ctrl + R to go in backward search
3. Hit Ctrl + C to exit Terraform console

Additional Context

You don't need any configuration file to reproduce this error, and doing it with configuration files present do not change the behavior, it seems to be consistent.

I may open a PR to to fix it when I have a bit of time

References

No response

[crw]

Thanks for this report!

[justincange]

I took a look into this and I think it might actually be a bug from the ReadLine library. I'm seeing they have a very similar problem on exiting the console in this issue here.

Edit: After a closer look I think this is just an issue with ReadLine, which is getting called in (and crashing) from the console.

[v1gnesh]

Seems like perfect timing.

@crw, could you please assess if chzyer/readline can be swapped out for a maintained fork - ergochat/readline?

chzyer/readline#226 (comment)

[slingamn]

Hi, I'm one of the ergochat/readline maintainers and I'm very interested in seeing if our fork is suitable for use in terraform! From my initial investigation:

1. Our latest release, v0.0.3, can be used in terraform as a drop-in replacement. (Please don't be scared off by the unstable version number; the excessive size of the upstream API had become a tarpit. We are working on shrinking the public API to something that is more maintainable.)
2. The panic from upstream's issue 163 is still present in our fork, but it should be an easy fix that I can work on immediately.

[slingamn]

I opened a PR for this: ergochat/readline#33

[slingamn]

I released the previously mentioned fix, released it as v0.0.5, and wrote a draft PR for Terraform that switches to ergochat/[email protected]: #33305

[crw]

Thanks for this information and the pull request! The question of changing / updating dependencies is being run past the security team. We appreciate the background and info on these libraries!