Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: bootstrap configuration should be ignored for existing EKS clusters #35824

Closed
Nuru opened this issue Feb 15, 2024 · 4 comments · Fixed by #38295
Closed

[Bug]: bootstrap configuration should be ignored for existing EKS clusters #35824

Nuru opened this issue Feb 15, 2024 · 4 comments · Fixed by #38295
Labels
bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@Nuru
Copy link

Nuru commented Feb 15, 2024

Terraform Core Version

1.7.3

AWS Provider Version

5.36.0

Affected Resource(s)

aws_eks_cluster

Expected Behavior

Setting bootstrap_cluster_creator_admin_permissions on an existing cluster should have no effect.

Actual Behavior

Setting bootstrap_cluster_creator_admin_permissions = true (the default value) on an existing cluster forces the cluster to be replaced.

  ~ access_config {
      ~ authentication_mode                         = "CONFIG_MAP" -> "API_AND_CONFIG_MAP"
      ~ bootstrap_cluster_creator_admin_permissions = false -> true # forces replacement
    }

Terraform Configuration Files

resource "aws_eks_cluster" "default" {
  # create the cluster without `access_config` and then uncomment the following
  /* 
  access_config {
    authentication_mode                         = "API_AND_CONFIG_MAP"
    bootstrap_cluster_creator_admin_permissions = true
  }
  */
  ...
}

Steps to Reproduce

  • Create an EKS cluster without specifying access_config at all
  • Modify the configuration adding the access_config block and setting
    • authentication_mode = "API_AND_CONFIG_MAP"
    • bootstrap_cluster_creator_admin_permissions = true

Important Factoids

The setting of bootstrap_cluster_creator_admin_permissions only matters during cluster creation. It should be ignored for existing clusters.

References

From containers-roadmap:

Note: The value that you set for bootstrapClusterCreatorAdminPermissions on cluster creation is not returned in the response of subsequent EKS DescribeCluster API calls. This is because the value of that field post cluster creation may not be accurate. Further changes to access control post cluster creation will always be performed with access entry APIs. The ListAccessEntries API is the source of truth for cluster access post cluster creation.

Would you like to implement a fix?

No

@Nuru Nuru added the bug Addresses a defect in current functionality. label Feb 15, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.58.0 milestone Jul 10, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
2 participants