Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Prefer aws.IsARN to strings.HasPrefix #32651

Open
jeremychauvet opened this issue Jul 23, 2023 · 1 comment
Open

[Enhancement]: Prefer aws.IsARN to strings.HasPrefix #32651

jeremychauvet opened this issue Jul 23, 2023 · 1 comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. question A question about existing functionality; most questions are re-routed to discuss.hashicorp.com.

Comments

@jeremychauvet
Copy link
Contributor

jeremychauvet commented Jul 23, 2023 •
edited
Loading

Description

Hello 👋🏼
I'm facing an issue with the automated acceptance testing, asking to use a method aws.IsARN rather than strings.HasPrefix.

I've checked if someone already use this method and it seems that no one do.

I would like to inquire whether this test serves a practical purpose, and if we should keep it :smi

Affected Resource(s) and/or Data Source(s)

N/A

Potential Terraform Configuration

N/A

References

No response

Would you like to implement a fix?

Yes
@jeremychauvet jeremychauvet added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jul 23, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added question A question about existing functionality; most questions are re-routed to discuss.hashicorp.com. linter Pertains to changes to or issues with the various linters. github_actions Pull requests that update Github_actions code and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. question A question about existing functionality; most questions are re-routed to discuss.hashicorp.com.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremychauvet @justinretzolk