Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional readiness probe configuration #95

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

rheyser
Copy link
Contributor

@rheyser rheyser commented Oct 23, 2024

When helm chart deploys deployment.yaml template, it will support optionally configuring the readiness probe to different url backends and schemes. This will allow customers to configure it to hit /_health_check?full rather than just /_health_check.

@rheyser rheyser requested a review from a team as a code owner October 23, 2024 14:40
Copy link

hashicorp-cla-app bot commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jkerry jkerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've noticed a few small changes that are necessary in testing. Once these are done, if you agree, then I'll get this re-validated and integrated.

templates/deployment.yaml Outdated Show resolved Hide resolved
templates/deployment.yaml Outdated Show resolved Hide resolved
@jkerry
Copy link
Contributor

jkerry commented Nov 8, 2024

Tested and confirmed! This change will go out with our next release.

@jkerry jkerry merged commit acfa445 into hashicorp:main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants