deployment: use overridden service account name if specified #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, if a `serviceAccount.name` is specified, the deployment would always use the namespace name as the name. After this patch, the `serviceAccountName` will check for a custom value before defaulting to the namespace
|
@jkerry @miguelhrocha could this get your attention? PR #91 was missing this change, causing anyone trying to use |
nikolasrieble
approved these changes
Oct 21, 2024
Comment on lines
+67
to
71
| {{- if .Values.serviceAccount.name}} | ||
| serviceAccountName: {{ .Values.serviceAccount.name }} | ||
| {{- else }} | ||
| serviceAccountName: {{ .Release.Namespace }} | ||
| {{- end }} |
There was a problem hiding this comment.
If we were to use the default function, this could be simplified a tad:
Suggested change
| {{- if .Values.serviceAccount.name}} | |
| serviceAccountName: {{ .Values.serviceAccount.name }} | |
| {{- else }} | |
| serviceAccountName: {{ .Release.Namespace }} | |
| {{- end }} | |
| serviceAccountName: {{ .Values.serviceAccount.name | default .Release.Namespace }} |
|
As this is a bug fix and we are preparing a release, lets land this. The suggested change is functionally equivalent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, if a
serviceAccount.nameis specified, the deployment would always use the namespace name as the name.After this patch, the
serviceAccountNamewill check for a custom value before defaulting to the namespaceRelated: #91