Skip to content

cdktf-cli: Invoke Terraform CLI with node:child_process instead of node-pty. (Bun + Deno support) #3675

Open
@commiterate

Description

@commiterate

Description

Issue

cdktf-cli currently uses @cdktf/node-pty-prebuilt-multiarch to spawn a child process that runs the Terraform CLI for deploy and destroy commands (docs). This is a fork of node-pty for providing pre-built binaries as it has native/C components.

This currently has some sharp edges:

  1. The Terraform CDK team needs to continuously maintain the fork and provide additional pre-built binaries for each combination of JavaScript runtime (Node.js, Electron) version, operating system (Linux w/ GNU libc, Linux w/ musl libc, macOS/Darwin, Windows), and ISA (IA-32/i386, x86-64, ARM32, ARM64).
  2. Pre-compiled binaries may contain hardcoded paths to the dynamic linker or expect specific versions of dynamically linked libraries.
    • The former requires ELF patching for operating systems that don't place the dynamic linker in a conventional location like NixOS and Guix.
    • The latter is a chronic inconvenience for people on usually older and the newest versions of Linux distributions which may have older/newer versions of GNU libc or musl libc than what's required.
  3. node-pty uses some V8-specific APIs which can cause problems for alternative runtimes that don't use V8 as the JavaScript engine.

node-pty effectively creates a hard dependency on the Node.js runtime (Node.js API + V8 JavaScript engine) and other pre-compiled binaries which creates a narrow compatibility window and an extra maintenance burden.

Proposal

One option is to use Node's child_process.spawn() (docs) to spawn child processes. Setting the stdio option (docs) to inherit seems to allow use of interactive child processes like the Terraform CLI.

This removes the need for binaries outside of the JavaScript runtime, leaving only a dependency on the Node.js API.

Alternative JavaScript runtimes typically provide polyfills for Node.js APIs. In particular, both Bun and Deno provide node:child_process polyfills, removing the need for cdktf-cli to use each runtime's idiomatic child process spawning APIs.

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestnewUn-triaged issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions