Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source maps from providers #3178

Open
1 task
pauldraper opened this issue Oct 6, 2023 · 1 comment
Open
1 task

Remove source maps from providers #3178

pauldraper opened this issue Oct 6, 2023 · 1 comment
Labels
enhancement New feature or request pre-built providers Issues around pre-built providers managed at https://github.com/hashicorp/cdktf-repository-manager priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes.

Comments

@pauldraper
Copy link

pauldraper commented Oct 6, 2023

Description

The @cdktf/provider-aws package is 342MB.

Removing the inline source maps would reduce that by ~35%.


References

No response

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@pauldraper pauldraper added enhancement New feature or request new Un-triaged issue labels Oct 6, 2023
@pauldraper pauldraper changed the title @cdktf/provider-aws is 342MB Remove source maps from providers Oct 6, 2023
@DanielMSchmidt
Copy link
Contributor

We added the source maps a while back on request of a user wo wanted to improve the jump to definition experience during development. I can see that the size is quite big but so is the underlying provider. By using specific imports one can reduce the compile time, so this improvement would most likely be only affecting the raw size of the package.

I can see the size being an annoyance but the missing source maps would be one as well, therefore we are awaiting evidence here that this is a worthwhile investment.

@DanielMSchmidt DanielMSchmidt added priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes. pre-built providers Issues around pre-built providers managed at https://github.com/hashicorp/cdktf-repository-manager and removed new Un-triaged issue labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pre-built providers Issues around pre-built providers managed at https://github.com/hashicorp/cdktf-repository-manager priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes.
Projects
None yet
Development

No branches or pull requests

3 participants