Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Support terraform_data built-in resource #3142

Closed
1 task done
ansgarm opened this issue Sep 22, 2023 · 2 comments · Fixed by #3317
Closed
1 task done

lib: Support terraform_data built-in resource #3142

ansgarm opened this issue Sep 22, 2023 · 2 comments · Fixed by #3317
Assignees
Labels
cdktf core-parity Better experience in Terraform Core than CDKTF enhancement New feature or request good first issue Good for newcomers help wanted Community contributions welcome as the core team is unlikely to work on this soon
Milestone

Comments

@ansgarm
Copy link
Member

ansgarm commented Sep 22, 2023

Description

Terraform 1.4 added support for a built-in terraform_data resource which can be used instead of the null resource. We should support it, too!

Note: We should ensure convert supports this as well!

References

Terraform PR: hashicorp/terraform#31757
Terraform Docs: https://developer.hashicorp.com/terraform/language/resources/terraform-data
Discuss thread asking for CDKTF support: https://discuss.hashicorp.com/t/how-to-use-terraform-data-in-cdk-tf/58390

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@ansgarm ansgarm added enhancement New feature or request good first issue Good for newcomers help wanted Community contributions welcome as the core team is unlikely to work on this soon cdktf core-parity Better experience in Terraform Core than CDKTF labels Sep 22, 2023
@pauldraper
Copy link

pauldraper commented Oct 6, 2023

Including @ansgarm's workaround here:

stack.addOverride("resource.terraform_data.replacement", {
  input: revision
})

@ansgarm ansgarm self-assigned this Dec 1, 2023
@xiehan xiehan added this to the 0.20 (tentative) milestone Dec 5, 2023
Copy link
Contributor

github-actions bot commented Jan 7, 2024

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cdktf core-parity Better experience in Terraform Core than CDKTF enhancement New feature or request good first issue Good for newcomers help wanted Community contributions welcome as the core team is unlikely to work on this soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants