Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-poetry to cdktf-cli built-in templates #2838

Open
garysassano opened this issue Apr 25, 2023 · 4 comments
Open

Add python-poetry to cdktf-cli built-in templates #2838

garysassano opened this issue Apr 25, 2023 · 4 comments
Labels
cdktf-cli enhancement New feature or request language/python priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes.

Comments

@garysassano
Copy link

Poetry has become the most popular tool for managing Python projects and also projen allows you to set up your repo with that. CDKTF already supports built-in templates for python (pipenv) and python-pip (pip) so I think there should be space for python-poetry (Poetry) as well.

There's also an existing template that works very well.

@garysassano garysassano added enhancement New feature or request new Un-triaged issue labels Apr 25, 2023
@ansgarm
Copy link
Member

ansgarm commented Apr 26, 2023

Hi @garysassano 👋

Thank you for raising this! This was originally discussed in a PR here which then ended up becoming the community template you linked.

Is there any data that you know of that could help to make the case in favor or Python Poetry? Personally, I'd rather replace one of the existing Python templates with the Poetry one, but this would require us to have some data that supports the higher popularity of Python Poetry over e.g. Pipenv.

@ansgarm ansgarm added language/python cdktf-cli priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes. and removed new Un-triaged issue labels Apr 26, 2023
@garysassano
Copy link
Author

I think Google Trends is quite good at providing some unbiased data showing the clear rise in popularity of Poetry over pipenv.

@aogier
Copy link

aogier commented Jul 13, 2023

considering that pypi installation method is now officially supported by either project, pypi download stats could prove a shift toward poetry:

where we can observe ~3x poetry installs

@aogier
Copy link

aogier commented Oct 8, 2023

update, since July poetry doubled its download https://pepy.tech/project/poetry . While this is not the definitive benchmark, it's also to be noted we don't have any evidence to the contrary :)

what do you think @ansgarm ? Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cdktf-cli enhancement New feature or request language/python priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes.
Projects
None yet
Development

No branches or pull requests

3 participants