-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add conditional skip for docs changes #560
Conversation
4550901
to
1d5ab56
Compare
skipped_directories=("_doc/" ".changelog/") | ||
|
||
# Loop through the changed files and find directories/files outside the skipped ones | ||
files_to_check_array=($files_to_check) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were not converting to an array in the original script - it happened to still work due to multiline matches, but this allows us to print individual debug logs more accurately
e940874
to
e2dffb4
Compare
@nathancoleman or @DanStough when you get a sec, could I get a follow-up review of this change too? (basically the same as #560 apart from exempt directory list and integrated workflows) |
e2dffb4
to
f663c26
Compare
- integration-tests | ||
runs-on: ubuntu-latest | ||
if: always() | ||
if: always() && needs.conditional-skip.outputs.skip-ci != 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the action won't get stuck because this job is required and there are cases where we won't run it, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. This follows the pattern in consul
here
f663c26
to
63d4bac
Compare
Removed dead env var accidentally left in from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Similar to
consul
, skip build and tests if we're only changing docs.This should help speed up releases and daily work quick-fixes.
After adding a code change: