Sign button doesn't disappear after signing

[jbair06]

Problem

When signing a transaction, the sign button doesn't go away even though I got a toast message saying the transaction was signed successfully. This is caused by a connection issue with the WebSocketGateway (e.g. ERROR [WebsocketGateway] Socket client connected without user).
As this bug allowed for a transition to be signed multiple times, it was noted that each time the transaction was signed, a new transaction was essentially created and submitted to the network. This is likely due to the transaction submitting to the network between the first signature and the second.
Due to multiple signings/transactions, the first transaction was successful, but subsequent transactions were marked as duplicate.

Solution

The root cause of the issue needs to be addressed, as well as adding safeguards for potentially related issues.

1. Discover why the websocket did not reconnect. This specific case happened due to a user having the app open and running while the notification service pod was redeployed. Websocket should have reconnected, but doesn't appear to have done so properly.
2. Determine if a client side health check and reconnect to the server feature is possible
3. Sign button could be changed to not rely solely on the websocket notification, but also on the response to the signing of the transaction. If a transaction is signed and the server responds with a successful upload, the sign button can be hidden.
4. On the back-end, if the transaction is already being executed, prevent further signatures
5. Ensure that a transaction doesn't get 'duplicated' due to the above.
6. When duplicate transactions are found in history, either display all transactions, or at least display the transaction that is not a duplicate so that history will show that the first transaction was successful.
7. If a transaction isn't actually duplicated, but instead has its status/response code updated due to the duplicate submission, don't allow the duplicate submission to overwrite the value of a successful submission.

Alternatives

No response

[SimiHunjan]

another user reported the same issue