Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new CI pipeline for release automation #2011

Merged
merged 25 commits into from
Nov 6, 2023

Conversation

nathanklick
Copy link
Member

@nathanklick nathanklick commented Nov 1, 2023

Description

This pull request changes the following:

  • Adds a CI release workflow which is triggered on a semantic version tag.
  • Standardizes all existing CI workflows to conform to best practices.
  • Upgrades the eslint node plugin to a non-deprecated version.
  • Disables some eslint rules causing the publish to fail.
  • Disables two unit tests which are consistently failing.

Related Issues

@nathanklick nathanklick force-pushed the 02006-CI-Publish-Pipeline branch from 9b73c0c to 4f19207 Compare November 1, 2023 16:26
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 791 lines in your changes are missing coverage. Please review.

Comparison is base (cab7be2) 76.94% compared to head (bc93479) 83.78%.
Report is 160 commits behind head on develop.

❗ Current head bc93479 differs from pull request most recent head 936871b. Consider uploading reports for the commit 936871b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2011      +/-   ##
===========================================
+ Coverage    76.94%   83.78%   +6.83%     
===========================================
  Files          292      304      +12     
  Lines        72743    75854    +3111     
===========================================
+ Hits         55971    63552    +7581     
+ Misses       16772    12302    -4470     
Files Coverage Δ
packages/cryptography/src/BadKeyError.js 82.60% <100.00%> (ø)
packages/cryptography/src/BadMnemonicReason.js 100.00% <ø> (ø)
packages/cryptography/src/encoding/der.js 91.41% <100.00%> (-0.06%) ⬇️
packages/cryptography/src/primitive/bip32.js 96.49% <100.00%> (+1.97%) ⬆️
packages/cryptography/src/primitive/bip39.js 100.00% <100.00%> (ø)
packages/cryptography/src/util/array.js 82.14% <100.00%> (ø)
packages/cryptography/src/util/derive.js 100.00% <100.00%> (ø)
src/BadEntityIdError.js 71.42% <100.00%> (ø)
src/Duration.js 100.00% <100.00%> (+3.03%) ⬆️
src/EthereumTransaction.js 93.35% <100.00%> (ø)
... and 167 more

... and 76 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

.github/workflows/build.yml Show resolved Hide resolved
@nathanklick nathanklick merged commit cc49d13 into develop Nov 6, 2023
8 checks passed
@nathanklick nathanklick deleted the 02006-CI-Publish-Pipeline branch November 6, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new CI pipeline for release automation
2 participants