Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-misc fails to build with Python 3.13 #30

Closed
penguinpee opened this issue Mar 7, 2024 · 2 comments
Closed

scikit-misc fails to build with Python 3.13 #30

penguinpee opened this issue Mar 7, 2024 · 2 comments

Comments

@penguinpee
Copy link
Contributor

Fedora is preparing for upgrading Python to version 3.13 (not yet released) in Fedora 41 (scheduled to be released in October). Part of that effort is rebuilding all packages using Python 3.13 pre-releases as they become available.

Currently scikit-misc fails to build using Python 3.13.0a4:

../skmisc/meson.build:22:15: ERROR: Command `/usr/bin/python3 -c 'import os
  os.chdir(os.path.join("..", "tools"))
  import numpy as np
  try:
    incdir = os.path.relpath(np.get_include())
  except Exception:
    incdir = np.get_include()
  print(incdir)
  '` failed with status 1.

I'm reporting this for awareness. I will also try to figure out what's causing the issue and, if I can, come up with a patch.

@has2k1 has2k1 pinned this issue Mar 7, 2024
@penguinpee
Copy link
Contributor Author

This turns out to be an issue with meson-python behaving differently with Python 3.12.

I executed above snippet in our build environment and it failed with:

Traceback (most recent call last):
  File "<string>", line 3, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'

I could simply add numpy as a build dependency and the issue would go away. But since I didn't need to do that in Python 3.12, I asked the package maintainer of meson-python in Fedora to take a look. After all it will still be a while before 3.13 is actually going to be released.

I'll follow up once I know more.

penguinpee added a commit to penguinpee/scikit-misc that referenced this issue Mar 25, 2024
has2k1 pushed a commit that referenced this issue May 14, 2024
has2k1 added a commit that referenced this issue Jun 20, 2024
has2k1 added a commit that referenced this issue Jun 20, 2024
@penguinpee
Copy link
Contributor Author

I believe this can be closed. PR #31 has been merged.

has2k1 added a commit that referenced this issue Jun 24, 2024
has2k1 added a commit that referenced this issue Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant