Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not install doom-py, is thers something to be done except the install instructions? #12

Open
qqadssp opened this issue Dec 22, 2018 · 8 comments

Comments

@qqadssp
Copy link

qqadssp commented Dec 22, 2018

I tried several times to install doom-py, including 'pip3 install doom-py', install from the source code, 'pip3 install ppaquette-gym-doom', it always failled. Is there something else I can do?

@kessler-frost
Copy link

Can you post the exact error you are getting here?
Also, try installing all of the dependencies first as mentioned here https://github.com/ppaquette/gym-doom. I also had several issues while trying to install doom-py and most of the time it was due to a dependency mismatch or something which gets mentioned in the error that occurs while running pip install doom-py.

@hardmaru
Copy link
Owner

hardmaru commented Dec 24, 2018 via email

@kessler-frost
Copy link

Ok @hardmaru, I'll contact the creator of that but I guess they will not reply since it's mentioned on the repo that it is not maintained now. Also there are several issues already present there which remain unattended. This is the reason I am trying to port your architecture to another gym environment.

@xiaoschannel
Copy link
Contributor

xiaoschannel commented Jan 17, 2019

I got doom-py to install, and now I am able to run ppaquette-gym-doom, up to the data generation part of this repo. Here's the errors I encountered and what I did:

Environment: Ubuntu 18.04, python3.5, gym 9.4 (a must).

Error 1: cerr not defined in std

modify corresponding file in vizdoom to add import iostream QupZilla/qupzilla#1122
the file might be in pip's cache and removed after. so you might need doom-py from source. but if you already have the proper version of vizdoom you can pip install doom-py later.

Error 2: freedoom-0.10.1.zip End-of-central-directory signature not found.

download freedoom manually Farama-Foundation/ViZDoom#184 (comment)

Error 3: libboost (I'm grouping it all together)

My Ubuntu comes with libboost 1.65.1, which removed boost::python::numeric (thanks to rdkit/rdkit#1581).
The solution that worked for me is to remove it and install 1.64.0 from source:
sudo apt remove --purge libboost*
This will remove all the libraries attached to libboost as well, which came relavant later.
Make sure you purged it clean with dpkg -l | grep boost and locate libboost, because if not, cmake might later find that and complain.
Now to download, build and install libboost 1.64 from source. The rough process is in one of the answers https://stackoverflow.com/questions/12578499/how-to-install-boost-on-ubuntu
There's two problem with the process there:

  1. Do not install libboost-all-dev with apt. this can happen when you copypastes one of those install dependency lines.
  2. Need to enable python by modifying project-config.jam after running bootstrapping.sh. Obviously you might have a different version and location, but here's what i added:
    using python : 3.5 : /home/**myname**/local/bin/python3 : /home/**myname**/local/include/python3.5m : /home/**myname**/local/lib ;
    When I uninstalled and purged libboost*, I also removed libsdl2-dev. So I also needed to sudo apt-get install libsdl2-dev.

I was able to get doom-py installed after this with simply pip3 install doom-py.

@hardmaru
Copy link
Owner

hardmaru commented Jan 17, 2019 via email

@Chazzz
Copy link

Chazzz commented Jan 19, 2019

I followed @zuoanqh instructions to build libboost manually and install all dependencies, but now it segfaults on run-time D:

Output

python3 model.py doomreal render log/doomrnn.cma.16.64.best.json
filename log/doomrnn.cma.16.64.best.json
model size 1088
making real doom environment
Segmentation fault (core dumped)

@xiaoschannel
Copy link
Contributor

xiaoschannel commented Jan 19, 2019 via email

@Chazzz
Copy link

Chazzz commented Jan 20, 2019

@zuoanqh I appreciate the help and would debug this issue further but something in the install process made my system go busto (don't worry I back up everything). Still I'm not super keen on reproducing the issue at the moment. Personally my priority is getting the model to run using atari_py, which offers a lot of benefits over the gyms chosen by the authors, including easy installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants