Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for complex channel names in ASC files #1860

Open
rettenbs opened this issue Sep 17, 2024 · 4 comments
Open

Add support for complex channel names in ASC files #1860

rettenbs opened this issue Sep 17, 2024 · 4 comments

Comments

@rettenbs
Copy link

Is your feature request related to a problem? Please describe.

We encountered an ASC file that contains channels names like Li:

  42.017364 Li 14              Rx     8 2a 79 00 00 00 80 c0 ff  checksum = 07   header time =  40, full time = 135  SOF =   42.010348   BR = 19200  break = 942203 109234   EOH =   42.012418    EOB =   42.012979    42.013527    42.014075    42.014623    42.015172    42.015720    42.016268    42.016816    sim = 0    EOF =   42.017364   RBR = 19157  HBR = 19202.640363  HSO = 22785     RSO = 22837     CSM = enhanced

The current ASC reader fails to parse these files, i.e. it skips these messages because channel has to be an int.

Describe the solution you'd like

Would it be possible to enhance the ASC reader to deal with the complex channel names?

@zariiii9003
Copy link
Collaborator

That's a LIN channel, not a CAN channel.

@rettenbs
Copy link
Author

This makes a lot of sense ... Thank you very much.

Do you think it is feasible to support LIN channels as well for ASC files? I know this is CAN library but it is the best reader for ASC files for Python.

@zariiii9003
Copy link
Collaborator

But what are we supposed to do with these lines? It does not make sense to return can.Message instances for LIN messages.

@rettenbs
Copy link
Author

I see. We would need a lin.Message. Probably beyond the scope of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants