Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure which images are to be pushed #23

Open
ludovicc opened this issue Aug 3, 2015 · 2 comments
Open

Configure which images are to be pushed #23

ludovicc opened this issue Aug 3, 2015 · 2 comments

Comments

@ludovicc
Copy link
Contributor

ludovicc commented Aug 3, 2015

Configure which images are to be pushed, e.g. to exclude test images.

I need this functionality soon... I think that it would be simpler if by default test images are never pushed.

@dkapanidis
Copy link
Member

The functionality is something I´m looking forward for also. Does a boolean field "disable_push" in captain.yml of specific image seem reasonable? (with default value false)

The auto exclude I find it useful, but rather heuristic, how can you identify which ones are test images? In my case I want to exclude compile images and deploy only runtime ones, but I´m sure there are other use cases that I don´t want to restrict it to specific context.

@paddie
Copy link

paddie commented Jul 20, 2016

The disable_push makes sense, as in:

hello-world:
  build: Dockerfile
  push: false # default to true
  image: harbur/hello-world
  pre:
    - echo "Preparing hello-world"
  post:
    - echo "Finished hello-world"
hello-world-test:
  build: Dockerfile.test
  push: false
  image: harbur/hello-world-test
  pre:
    - echo "Preparing hello-world-test"
  post:
    - echo "Finished hello-world-test"
  test:
    - docker run -e NODE_ENV=TEST harbur/hello-world-test node mochaTest
    - docker run -e NODE_ENV=TEST harbur/hello-world-test node karmaTest
project-with-build-args:
  build: Dockerfile
  push: false
  image: harbur/buildargs
  build_arg:
    keyname: keyvalue

I'd like to play around with this a bit more, but I see this as something that would conflict with out current use-case. Some way of running calling captain run --suffix test and having it map only to Docker.test files might also be interesting..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants