You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't really want pod restarts either, whatever helm mentions as best practice, it's not necessarily applicable to everything, especially for Ingress Controller services that we want to be restarted as little as possible.
The use-case in #275 was to make global, frontend or backend config snippets parametrizable like this:
As @dkorunic pointed out this will cause pods to restart which we want to avoid. Instead we could make controller.config templatable and achieve the same without restart:
# values-common.yamlkubernetes-ingress:
controller:
config: | frontend-config-snippet: | # ... .if streq("${.SECTION}",https) maxconn {{ .Values.customVars.maxconnFrontendHttps | required "customVars.maxconnFrontendHttps must be defined" }} .endif # ...customVars:
# default value to be overriddenmaxconnFrontendHttps: 30000
The config is equivalent to the snippet above, but we now have additional validation preventing empty values to be inserted.
Whenever the config changes, the configmap is re-ingested by the IC and haproxy is reloaded. No restart necessary.
The same use-cases as in #275 apply here: Parametrizing config snippets so single variables can be different on different deployments, better separation of config and sets of tunables that are of interest to different teams in an organization (see this example).
This would not make #275 obsolete as templatable podAnnotations are still needed when changing haproxy-auxiliary-configmap (docs) as is can be only refreshed via pod restart.
The text was updated successfully, but these errors were encountered:
Hi,
I thought about what @dkorunic said in this comment. Especially
The use-case in #275 was to make global, frontend or backend config snippets parametrizable like this:
As @dkorunic pointed out this will cause pods to restart which we want to avoid. Instead we could make
controller.config
templatable and achieve the same without restart:The config is equivalent to the snippet above, but we now have additional validation preventing empty values to be inserted.
Whenever the config changes, the configmap is re-ingested by the IC and haproxy is reloaded. No restart necessary.
The same use-cases as in #275 apply here: Parametrizing config snippets so single variables can be different on different deployments, better separation of config and sets of tunables that are of interest to different teams in an organization (see this example).
This would not make #275 obsolete as templatable podAnnotations are still needed when changing
haproxy-auxiliary-configmap
(docs) as is can be only refreshed via pod restart.The text was updated successfully, but these errors were encountered: