Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super_resolution should be True? #13

Open
m-mandel opened this issue Jul 13, 2022 · 1 comment
Open

super_resolution should be True? #13

m-mandel opened this issue Jul 13, 2022 · 1 comment

Comments

@m-mandel
Copy link

Should the configuration for super resolution be as follows?

 "ssr":{
      "ssr_task": {
        "dereverberation": false,
        "denoising": false,
        "declipping": false,
        "super_resolution": true
      },

instead of:

 "ssr":{
      "ssr_task": {
        "dereverberation": false,
        "denoising": true,
        "declipping": false,
        "super_resolution": false
      },
@haoheliu
Copy link
Owner

haoheliu commented Aug 3, 2022

Hi @mosem Thanks for pointing out. This part of configuration is a little bit redundancy, which means it's not actually used by code. So changing this part will not affect the program behavior. Many apologizes for the confusion. I'll try to fix this issue and resolve the confusion lately.

Haohe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants