Add directories.rb recipe extracting from base.rb

Signed-off-by: Edoardo Antonini <[email protected]>

Author: eantonin

cookbooks/aws-parallelcluster-install/recipes/base.rb

@@ -29,21 +29,7 @@
   end
 end
 
-# Setup directories
-directory '/etc/parallelcluster'
-directory node['cluster']['base_dir']
-directory node['cluster']['sources_dir']
-directory node['cluster']['scripts_dir']
-directory node['cluster']['license_dir']
-directory node['cluster']['configs_dir']
-directory node['cluster']['shared_dir']
-
-# Create ParallelCluster log folder
-directory '/var/log/parallelcluster/' do
-  owner 'root'
-  mode '1777'
-  recursive true
-end
+include_recipe "aws-parallelcluster-install::directories"
 
 build_essential
 include_recipe "aws-parallelcluster-install::python"

cookbooks/aws-parallelcluster-install/recipes/directories.rb

@@ -0,0 +1,30 @@
+#
+# Cookbook:: aws-parallelcluster
+# Recipe:: directories
+#
+# Copyright:: 2013-2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You may not use this file except in compliance with the
+# License. A copy of the License is located at
+#
+# http://aws.amazon.com/apache2.0/
+#
+# or in the "LICENSE.txt" file accompanying this file. This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES
+# OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Setup directories
+directory '/etc/parallelcluster'
+directory node['cluster']['base_dir']
+directory node['cluster']['sources_dir']
+directory node['cluster']['scripts_dir']
+directory node['cluster']['license_dir']
+directory node['cluster']['configs_dir']
+directory node['cluster']['shared_dir']
+
+# Create ParallelCluster log folder
+directory '/var/log/parallelcluster/' do
+  owner 'root'
+  mode '1777'
+  recursive true
+end

kitchen.recipes.yml

@@ -29,3 +29,12 @@ suites:
       controls:
         - admin_user
         - ulimit
+  - name: directories
+    run_list:
+      # runs the recipe to test, along with the recipes it depends on
+      - recipe[aws-parallelcluster::test_dummy]
+      - recipe[aws-parallelcluster-install::directories]
+    verifier:
+      controls:
+        - pcluster_directories_exist
+        - pcluster_log_dir_is_configured

test/recipes/controls/aws_parallelcluster_install/directories_spec.rb

@@ -0,0 +1,21 @@
+control 'pcluster_directories_exist' do
+  title 'Setup of ParallelCluster directories'
+
+  base_dir = "/opt/parallelcluster"
+  dirs = [ base_dir, "#{base_dir}/sources", "#{base_dir}/scripts", "#{base_dir}/licenses", "#{base_dir}/configs", "#{base_dir}/shared" ]
+  dirs.each do |path|
+    describe directory(path) do
+      it { should exist }
+    end
+  end
+end
+
+control 'pcluster_log_dir_is_configured' do
+  title 'Setup of ParallelCluster log folder'
+
+  describe directory("/var/log/parallelcluster") do
+    it { should exist }
+    its('owner') { should eq 'root' }
+    its('mode') { should cmp '01777' }
+  end
+end