diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index dc9325c..0ef5741 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,23 +10,23 @@ jobs: strategy: matrix: - go-version: [ 1.17, 1.18 ] + go-version: [ 1.18, 1.19 ] runs-on: ubuntu-latest env: - GOLANGCI_LINT_VERSION: v1.46.2 + GOLANGCI_LINT_VERSION: v1.48.0 steps: - name: Install Go if: success() - uses: actions/setup-go@v2 + uses: actions/setup-go@v3 with: go-version: ${{ matrix.go-version }} - name: Checkout code - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Cache Go modules - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ~/go/pkg/mod key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} @@ -34,7 +34,7 @@ jobs: ${{ runner.os }}-go- - name: Run linter - uses: golangci/golangci-lint-action@v2 + uses: golangci/golangci-lint-action@v3 with: version: ${{ env.GOLANGCI_LINT_VERSION }} args: --go ${{ matrix.go-version }} @@ -43,7 +43,7 @@ jobs: run: go test -covermode=count -coverprofile=coverage.out ./... - name: Convert coverage.out to coverage.lcov - uses: jandelgado/gcov2lcov-action@v1.0.6 + uses: jandelgado/gcov2lcov-action@v1 - name: Coveralls uses: coverallsapp/github-action@v1.1.2 with: diff --git a/doc.go b/doc.go index 365fe0f..4b8d319 100644 --- a/doc.go +++ b/doc.go @@ -4,6 +4,7 @@ Package cmd implements cmd helpers. This provides helpers on top of `github.com/urfave/cli`. Example usage: + var c *cli.Context // Get this from your action log, err := cmd.NewLogger(c) diff --git a/trace_test.go b/trace_test.go index 6aec39f..d0078ab 100644 --- a/trace_test.go +++ b/trace_test.go @@ -26,46 +26,46 @@ func TestNewTracer(t *testing.T) { wantErr: require.NoError, }, { - name: "jaeger", + name: "jaeger", exporter: "jaeger", endpoint: "localhost:1234", ratio: 1.0, - wantErr: require.NoError, + wantErr: require.NoError, }, { - name: "jaeger invalid endpoint", + name: "jaeger invalid endpoint", exporter: "jaeger", endpoint: "localhost", ratio: 1.0, - wantErr: require.Error, + wantErr: require.Error, }, { - name: "zipkin", + name: "zipkin", exporter: "zipkin", endpoint: "http://localhost:1234/api/v2", ratio: 1.0, - wantErr: require.NoError, + wantErr: require.NoError, }, { - name: "unknown exporter", + name: "unknown exporter", exporter: "some-exporter", endpoint: "localhost:1234", ratio: 1.0, - wantErr: require.Error, + wantErr: require.Error, }, { - name: "ratio too low", + name: "ratio too low", exporter: "jaeger", endpoint: "localhost:1234", ratio: -1.0, - wantErr: require.NoError, + wantErr: require.NoError, }, { - name: "ratio too high", + name: "ratio too high", exporter: "jaeger", endpoint: "localhost:1234", ratio: 2.0, - wantErr: require.NoError, + wantErr: require.NoError, }, }