Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark vs Light theme selection #512

Open
ganomi46 opened this issue Aug 15, 2024 · 5 comments
Open

Dark vs Light theme selection #512

ganomi46 opened this issue Aug 15, 2024 · 5 comments

Comments

@ganomi46
Copy link

Would it be possible to have light theme as default and button to allow the visitor to change the theme. I received a lot of feedback on why the theme is dark. It seem the automatic change by the browser is not very welcome. Thx

@ripienaar
Copy link

Strong agree, I am a huge fan of dark themes and set everything possible to dark - but this one is just not good and it's ruined beautifulhugo for me.

@Xhanti
Copy link

Xhanti commented Aug 19, 2024

I also agree. It threw me a bit not being able to change it to light mode. It would be great to allow the user to control it.

@henryiii
Copy link
Collaborator

IMO, this is really a problem with browsers. They should provide a toggle to override the system setting, ideally per webpage. Asking webpages to all add custom toggles seems wasteful and silly. But I'd be fine with a well-implemented selector. Improvements to the colors in dark mode would be welcome as well if there's an issue with it being "not good".

@henryiii
Copy link
Collaborator

(#500 doubles the number of CSS files and doesn't add a toggle, it just lets the site author select a "non-changing light-only" theme, basically.)

@hydr0nium
Copy link
Contributor

Yes I agree with @henryiii that it's a browser problem, but I have also been a big advocate for a change theme button. I am not really experienced with CSS, HTML much so I would be happy if someone could implement that feature. I would also be down to help as much as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants