feat: GeoJSON/JSON wizard additional settings page #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stempler
reviewed
Aug 21, 2023
io/plugins/eu.esdihumboldt.hale.io.json.ui/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
io/plugins/eu.esdihumboldt.hale.io.json.ui/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
...s/eu.esdihumboldt.hale.io.json.ui/src/eu/esdihumboldt/hale/io/json/ui/TypeSelectionPage.java
Show resolved
Hide resolved
...s/eu.esdihumboldt.hale.io.json.ui/src/eu/esdihumboldt/hale/io/json/ui/TypeSelectionPage.java
Outdated
Show resolved
Hide resolved
...s/eu.esdihumboldt.hale.io.json.ui/src/eu/esdihumboldt/hale/io/json/ui/TypeSelectionPage.java
Outdated
Show resolved
Hide resolved
...s/eu.esdihumboldt.hale.io.json.ui/src/eu/esdihumboldt/hale/io/json/ui/TypeSelectionPage.java
Outdated
Show resolved
Hide resolved
...umboldt.hale.io.json.ui/src/eu/esdihumboldt/hale/io/json/ui/util/EnumJSONAutoOrderTypes.java
Outdated
Show resolved
Hide resolved
...s/eu.esdihumboldt.hale.io.json.ui/src/eu/esdihumboldt/hale/io/json/ui/TypeSelectionPage.java
Outdated
Show resolved
Hide resolved
stempler
approved these changes
Aug 22, 2023
| /** | ||
| * @return the label | ||
| */ | ||
| public String getLabel() { |
There was a problem hiding this comment.
FYI Label is a public property, so you could have just accessed it directly.
Add 3 parameters for the reader that should be configurable via the UI: -A “read mode” that controls what kind of document structure can be parsed -A type name (QName string representation similar to how it is used for Shapefile and CSV readers) for the default type to associate to read instances -A setting to force the above default type to be used ING-3128
Add settings from JSON UI ING-3128
Remove unnecessary files. Update TypeSelection by creating the elements in the createContent method, update header. ING-3128
emanuelaepure10
force-pushed
the
ING-3128
branch
from
ec6138a
to
de11a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3 parameters for the reader that should be configurable via the UI:
-A “read mode” that controls what kind of document structure can be parsed
-A type name (QName string representation similar to how it is used for Shapefile and CSV readers) for the default type to associate to read instances
-A setting to force the above default type to be used
ING-3128