feat: type selection broken on custom export config #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuelaepure10
force-pushed
the
ING-3987
branch
2 times, most recently
from
fd56e08
to
3bfd70a
Compare
stempler
reviewed
Aug 18, 2023
...boldt.hale.io.csv.ui/src/eu/esdihumboldt/hale/io/csv/ui/InstanceExportConfigurationPage.java
Outdated
Show resolved
Hide resolved
...dt.hale.io.xls.ui/src/eu/esdihumboldt/hale/io/xls/ui/XLSInstanceExportConfigurationPage.java
Outdated
Show resolved
Hide resolved
...dt.hale.io.xls.ui/src/eu/esdihumboldt/hale/io/xls/ui/XLSInstanceExportConfigurationPage.java
Outdated
Show resolved
Hide resolved
emanuelaepure10
force-pushed
the
ING-3987
branch
from
3bfd70a
to
bb6c66e
Compare
stempler
approved these changes
Aug 21, 2023
...dt.hale.io.xls.ui/src/eu/esdihumboldt/hale/io/xls/ui/XLSInstanceExportConfigurationPage.java
Outdated
Show resolved
Hide resolved
...dt.hale.io.xls.ui/src/eu/esdihumboldt/hale/io/xls/ui/XLSInstanceExportConfigurationPage.java
Outdated
Show resolved
Hide resolved
CSV: Add a warning label to CSV dialog telling that feature types without data are not selectable. XSL: remove the button "Ignore feature types without data" and add intro the checkbox table disabled from selection elements that don't have any data for export. ING-3987
Update CSV InstanceExportConfigurationPage with the same approach used by XLS for finding which feature types has data or not. Remove unused method from XLSInstanceExportConfigurationPage ING-3987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV: Add a warning label to CSV dialog telling that feature types without data are not selectable.
XSL: remove the button "Ignore feature types without data" and add intro the checkbox table disabled from selection elements that don't have any data for export.
ING-3987