Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint 4.x fixup! feat download wfs files to tmp folder for bucket service #1049 #1050

Conversation

kapil-agnihotri
Copy link
Member

No description provided.

kapil-agnihotri and others added 30 commits August 7, 2023 10:28
Migrate from groovy 2.4 to 4.0.1 and
Migrate from pegdown to flexmark-java
markdown parser 0.64

ING-3268
Importing Junit as bundle instead of import-package because
tycho complained for unresolved dependency for org.junit and hamcrest

ING-3267
pending things:
- update bundled jre with jdk18 instead of jdk8
- for some reason this build is generating installables only for mac,
   So fix the script to create installables for windows and linux.
- remove commets
- this build will still not work in Jenkins as Jenkins should also be updated with Java 18

ING-3267
Update to groovy 2.5 because sandbox
cannot be updated with groovy 4.0.1.

ING-3267
Tests with the workflow were successful, however at the moment we still
use Jenkins.
With the previous `--add-exports`, the build process would generate the
following segment in HALE.ini:

```
--add-exports
java.base/sun.nio.ch=ALL-UNNAMED
java.base/jdk.internal.ref=ALL-UNNAMED
```

This leads to hale»studio being unstartable at least on Linux where it gives
the following exception:

```
$ ./HALE
Error: Could not find or load main class java.base.jdk.internal.ref=ALL-UNNAMED
Caused by: java.lang.ClassNotFoundException: java.base.jdk.internal.ref=ALL-UNNAMED
```

With the `--add-exports=` notation, the following segment in HALE.ini is
generated instead which allows hale»studio to start correctly:

```
--add-exports=java.base/sun.nio.ch=ALL-UNNAMED
--add-exports=java.base/jdk.internal.ref=ALL-UNNAMED
```

ING-3267
Adding 1 to Long.MAX_VALUE results in `overflow` exception
when converting BigInteger string into Long.
So added an empty string instead of adding 1

ING-3267
kapil-agnihotri and others added 26 commits August 7, 2023 10:29
Update infocenter container with the newly added page

ING-3370
Changes spelling in the application except for the help pages.
Adds the Nashorn JavaScript engine and its dependencies. The engine is
needed to run the `<script>` Ant tasks that are part of the Windows MSI
build. Nashorn was previously part of the JDK but was removed with the
release of Java 15.

ING-3370
Adds a parameter to the GeoPackage writer that allow overwriting the target
file if it exists. The parameter is disabled by default so that data is
appended to an existing file unless overwriting is explicitly requested.

refs halestudio#988
groovy-jfrog.io artifactory no longer contains jar:
org.osgi:org.osgi.service.prefs:jar:1.1.2, so priority
list of pluginRepositories is now changed to include
maven central on top
* Update test and writer

From the test class the whenReadWithBufferedReader_thenCorrect() and testCPGFileCreation() have been removed and a new method testCpgFileAgainstRelatedSpapefile() called from all the Test methods.
The writer has been updated taking the charset from the ShapefileDataStore of the related shapefile or adding the default charset in case the above one is null

feat: extend shapefile writer to create .cpg file

Create .cpg file/files when one/more .shp files are created.
The .cpg file contain only the encoding used to write the shapefile.
Create test for creating .cpg file

* feat: extend shapefile writer to create .cpg file

Create .cpg file/files when one/more .shp files are created.
The .cpg file contain only the encoding used to write the shapefile.
Create test for checking .cpg file content against related .shp file

* Set the charset to the writer as well as is done in the reader

Update test containing text with special characters

Decode the encoded text containing special characters
Change changelog.md and toc.xml
add a new file for 5.0.1.xhtml + images related
ING-3128
* fix: fix Groovy compiler level in Eclipse projects
* build: fix missing package import for test bundle
* refactor: delete obsolete JSON related classes
* refactor: rename JSON writer package
* refactor: stub implementation of reading JSON instances
* refactor: don't use outdated jackson library for Json processing
* feat: improve content type matching based on extension
Value matches related to file extensions higher depending on the number
if dots they contain.
Goal is to for example not match a `.xml.gz` file to a random content
type with a `gz` extension, but to prefer the one with `xml.gz`.
* feat: export multiple feature type to Excel

HALE studio supports selecting multiple feature types for export to Excel.
Each selected feature type is added as a separate sheet in a single Excel workbook.
Feature types without data are exported by default and left out if the button  "Ignore feature types without data" is checked.

ING-3941
The following changes have been done to solve the windows installer build error:
- add encoding UTF-8 to all the replace into file
- add more details in how to create the windows installer
- update GUID used for shortcuts.

ING-3831
Update CHANGELOG.md

ING-3831
Refactor to rename downloaded file to not start with
a "." and to have name format as
<datasetId>_<numberOfTotalFeatureProcessed>

ING-3609
@kapil-agnihotri kapil-agnihotri force-pushed the maint-4.x-fixup!-feat-download-wfs-files-to-tmp-folder-for-bucket-service-#1049 branch from 427f85f to 8e10178 Compare August 7, 2023 08:29
@kapil-agnihotri
Copy link
Member Author

Closing the PR as it has unwanted changes

@kapil-agnihotri kapil-agnihotri deleted the maint-4.x-fixup!-feat-download-wfs-files-to-tmp-folder-for-bucket-service-#1049 branch August 7, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants