Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Preserve unit for some 0 values #11

Closed
iamvdo opened this issue Jun 30, 2014 · 2 comments · Fixed by #12
Closed

Preserve unit for some 0 values #11

iamvdo opened this issue Jun 30, 2014 · 2 comments · Fixed by #12

Comments

@iamvdo
Copy link
Contributor

iamvdo commented Jun 30, 2014

There are bugs with some unitless 0.

For example, here are two examples with times (check in Chrome and Firefox to see differences)

http://jsbin.com/ledeb/2/edit
http://dabblet.com/gist/3746116

sand msunit should be preserved, even with 0.

CSSShrink also preserved unit for angles, even when 0, but I didn't find any use-case...
@hail2u
Copy link
Owner

hail2u commented Jun 30, 2014

Thanks, I don't know that.

hail2u pushed a commit that referenced this issue Jun 30, 2014
Don't remove unit from 0s and 0ms
ab548d6 
Resolves #11
@hail2u hail2u mentioned this issue Jun 30, 2014
Merged
@iamvdo
Copy link
Contributor Author

iamvdo commented Jul 3, 2014

Comment from @thierryk about unitless 0: stoyan/cssshrink#10 (comment)

@hail2u hail2u mentioned this issue Jun 22, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't remove unit from 0s and 0ms hail2u/node-csswring
2 participants
@hail2u @iamvdo