Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facet chapter still uses the classic formula-based interface #342

Open
djnavarro opened this issue Jan 23, 2023 · 3 comments
Open

facet chapter still uses the classic formula-based interface #342

djnavarro opened this issue Jan 23, 2023 · 3 comments

Comments

@djnavarro
Copy link
Collaborator

need to switch from facet_grid(a ~ b) to facet_grid(rows = vars(a), cols = vars(b)) etc

@hadley
Copy link
Owner

hadley commented Jan 23, 2023

FWIW I think we're rather lukewarm on the new syntax, so I wouldn't go out of my way to switch to it.

@djnavarro
Copy link
Collaborator Author

Noted 😁

I actually don't mind the new syntax. It is clunky in some ways, but I feel that's a consequence of vars()? The two-sided formula version was always a headache for me: I never had a good way of remembering whether LHS maps to rows or columns. But point taken... there are higher priorities!

@hadley
Copy link
Owner

hadley commented Feb 3, 2023

I think if we were to do this again it would be facet_grid(rows = a, cols = b), but we can't easily back out of the vars() syntax 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants