Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cabal-fmt, and re-enable in CI #685

Closed
brprice opened this issue Sep 8, 2022 · 1 comment · Fixed by #699
Closed

Bump cabal-fmt, and re-enable in CI #685

brprice opened this issue Sep 8, 2022 · 1 comment · Fixed by #699
Assignees
@brprice
Labels
blocked/upstream ❌ Blocked by upstream issue CI CI-related easy Should be straightforward to fix

Comments

@brprice
Copy link
Contributor

brprice commented Sep 8, 2022 •
edited
Loading

cabal-fmt does not support multi-library packages fully. This has been fixed upstream, but no release yet made. When one is, we should bump our version and re-enable the CI check. (I.e. revert the commit 549f53e)

Originally discussed in #626 (comment)

Upstream issue asking for a release phadej/cabal-fmt#54
@brprice brprice added blocked/upstream ❌ Blocked by upstream issue easy Should be straightforward to fix CI CI-related labels Sep 8, 2022
@brprice brprice self-assigned this Sep 8, 2022
@brprice
Copy link
Contributor Author

brprice commented Sep 21, 2022 •
edited
Loading

cabal-fmt 0.1.6 is now out, so I can action this.
Edit: or at least in a few days, when hackage.nix catches up https://github.com/input-output-hk/hackage.nix/blob/master/nix/cabal-fmt.nix

@brprice brprice linked a pull request Sep 22, 2022 that will close this issue
test: re-enable cabal-fmt for primer-service #699
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brprice brprice

Labels
blocked/upstream ❌ Blocked by upstream issue CI CI-related easy Should be straightforward to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: re-enable cabal-fmt for primer-service hackworthltd/primer
1 participant
@brprice