Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document/improve "raw" generator #186

Closed
brprice opened this issue Oct 26, 2021 · 0 comments · Fixed by #192
Closed

Document/improve "raw" generator #186

brprice opened this issue Oct 26, 2021 · 0 comments · Fixed by #192
Assignees
@brprice
Labels
documentation Improvements or additions to documentation easy Should be straightforward to fix primer Specific to the primer package quick This issue can probably be fixed relatively quickly testing Related to tests/testing

Comments

@brprice
Copy link
Contributor

brprice commented Oct 26, 2021

It turns out that Gen.Core.Raw has rather poor coverage: it does not even generate lambdas! This recently bit me in #180, where I assumed that this module would generate ill-scoped terms, but quickly and with decent coverage (which is what I wanted for "is this serialisation injective?").

We should at least document what Gen.Core.Raw is expected to generate, and perhaps improve the implementation to match. (For example, there is a note that it doesn't generate polytypes "because the rest of the system doesn't support them", which is clearly now incorrect).
@brprice brprice added quick This issue can probably be fixed relatively quickly testing Related to tests/testing documentation Improvements or additions to documentation easy Should be straightforward to fix primer Specific to the primer package labels Oct 26, 2021
@brprice brprice self-assigned this Oct 26, 2021
@brprice brprice mentioned this issue Oct 26, 2021
Merged
@brprice brprice linked a pull request Nov 4, 2021 that will close this issue
Gen.Core.Raw: cover all constructors #192
Merged
@ghost ghost closed this as completed in #192 Nov 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brprice brprice

Labels
documentation Improvements or additions to documentation easy Should be straightforward to fix primer Specific to the primer package quick This issue can probably be fixed relatively quickly testing Related to tests/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gen.Core.Raw: cover all constructors hackworthltd/primer
1 participant
@brprice