Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify db docker service to use the env file #309

Open
3 tasks done
fyliu opened this issue Jun 11, 2024 · 1 comment · May be fixed by #437
Open
3 tasks done

Modify db docker service to use the env file #309

fyliu opened this issue Jun 11, 2024 · 1 comment · May be fixed by #437
Assignees
@del9ra
Labels
complexity: medium feature: infrastructure For changes on site technical architecture role: back end role: dev ops s: PD team stakeholder: People Depot Team size: 0.25pt Can be done in 0.5-1.5 hours
Milestone
v0.01. Initial Setup

Comments

@fyliu
Copy link
Member

fyliu commented Jun 11, 2024 •
edited by del9ra
Loading

Overview

We should change the db docker container to use the same .env file that the web container reads, so that we're not hard-coding the values in the docker-compose.yml file.

Action Items

  • change docker-compose.yml to reference the .env.docker file
  • change the .env.docker-example file to contain the variables the db container needs
    • if necessary, change the django settings (settings.py) code to use the database variable names that the db container uses

Resources/Instructions

  • the db container should have an env_file key like the web container does
    image
@fyliu fyliu added good first issue Good for newcomers role: back end feature: infrastructure For changes on site technical architecture s: PD team stakeholder: People Depot Team role: dev ops size: 0.25pt Can be done in 0.5-1.5 hours ready for product labels Jun 11, 2024
@fyliu fyliu added this to the v0.01 - initial setup milestone Jun 11, 2024
@github-project-automation github-project-automation bot moved this to New Issue Review in P: PD: Project Board Jun 11, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Review to Prioritized Backlog in P: PD: Project Board Jun 24, 2024
@del9ra del9ra self-assigned this Sep 27, 2024
@shmonks
Copy link
Member

shmonks commented Oct 3, 2024

Hi @del9ra - please consider the following questions and add an update below:

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (if necessary): "Add any pictures that will help illustrate what you are working on."

@del9ra del9ra self-assigned this Nov 13, 2024
@del9ra del9ra linked a pull request Nov 14, 2024 that will close this issue
Open
@del9ra del9ra moved this from 📋Prioritized Backlog to 🏗In progress-actively working in P: PD: Project Board Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@del9ra del9ra

Labels
complexity: medium feature: infrastructure For changes on site technical architecture role: back end role: dev ops s: PD team stakeholder: People Depot Team size: 0.25pt Can be done in 0.5-1.5 hours
Projects
P: PD: Project Board
Status: 🏗In progress-actively working
Milestone
v0.01. Initial Setup
Development

Successfully merging a pull request may close this issue.

Modify db docker service to use the env file del9ra/peopledepot
4 participants
@fyliu @ExperimentsInHonesty @del9ra @shmonks