Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Audit Colors] in Privacy Policy page #827

Closed
14 tasks done
Tracked by #823
anitadesigns opened this issue Feb 16, 2023 · 10 comments
Closed
14 tasks done
Tracked by #823

[Audit Colors] in Privacy Policy page #827

anitadesigns opened this issue Feb 16, 2023 · 10 comments
Labels
feature: design system issues relating to the general design system feature: figma wireframes priority: high role: design anything related to design size: 1pt can be done in 6 hours or less
Milestone
Systems / Foundat...

Comments

@anitadesigns
Copy link
Member

anitadesigns commented Feb 16, 2023 •
edited
Loading

Overview

Extension of #823 . Audit mobile and desktop wireframes under "Design System Audit" on Figma. This issue is split into two parts: Auditing Mobile/Desktop wireframes and Auditing screenshot of page on expungeassist.org

Action Items

Auditing Mobile/Desktop wireframes

  • Select each individual "atom" on a wireframe
  • Assess what Hex code and color style is being used
  • Add metadata (color swap, location, style being used, Hex code, opacity )
    Example:
    Screen Shot 2023-04-26 at 9 01 03 PM
  • Use AutoFlow plugin to draw an arrow to each "atom" and element's color metadata
    • If "atom" is not using a color style, use the Orange (color style saved in Figma library) arrow and note the HEX code being used
    • If an old color style is being used, change the text sharing location and color style to red (use color style saved in Figma library)
  • Note any inconsistencies to share with the team

Auditing screenshot of page on expungeassist.org

  • Use Google Chrome's "inspect" tool to view website's code
  • Assess what Hex code
  • Add metadata on the screenshot in Figma (color swap, location, hex code)
  • Draw an arrow from element to metadata on Figma

Next steps

  • Comment in this issue "Completed. Ready for Review" and tag "@anitadesigns". Add any other information that is important to share in the comments
  • Unassign yourself and assign "@anitadesigns " to issue
  • Move issue from "In Progress" to "Ready for Review" on the project board

Resources/Instructions

Reach out to @anitadesigns if you have any questions.

You can find access to the space to audit this page under the "Design System Audit" in Figma
@anitadesigns anitadesigns added role: design anything related to design priority: high size: 1pt can be done in 6 hours or less feature: design system issues relating to the general design system feature: figma wireframes labels Feb 16, 2023
@anitadesigns anitadesigns mentioned this issue Feb 16, 2023
Closed
22 tasks
@anitadesigns anitadesigns assigned ermbrown and unassigned phuonguvan Apr 27, 2023
@ermbrown ermbrown removed their assignment May 2, 2023
@ermbrown
Copy link
Member

ermbrown commented May 2, 2023

@anitadesigns Please assign me to this task.

@ermbrown ermbrown assigned ermbrown and anitadesigns and unassigned ermbrown May 3, 2023
@anitadesigns
Copy link
Member Author

@ermbrown Looks good! I left a comment on one header that was missed in the mobile wireframe! Would you feel comfortable tackling the live website audit?

@anitadesigns anitadesigns assigned ermbrown and unassigned anitadesigns May 8, 2023
@anitadesigns
Copy link
Member Author

Assigning @ermbrown back to the issue to tackle the live website audit for this page.

@ermbrown
Copy link
Member

ermbrown commented May 8, 2023

Resolved :)

@ermbrown ermbrown assigned anitadesigns and unassigned ermbrown May 9, 2023
@ermbrown
Copy link
Member

ermbrown commented May 9, 2023 •
edited
Loading

Completed. Ready for review.

In the Live Website section, I noted that they had "no style" because of the inability to see the colors from Figma. I'm not sure if that was the correct label.

@anitadesigns
Copy link
Member Author

@ermbrown Missing jss rule in annotations. Left comments in Figma

@ermbrown
Copy link
Member

Completed. Ready for review.

@ermbrown ermbrown assigned anitadesigns and unassigned ermbrown May 28, 2023
@anitadesigns anitadesigns removed their assignment Jun 19, 2023
@anitadesigns
Copy link
Member Author

re-assigning to @ermbrown to update live website annotations. Please sub jss codes with hex code as shown in the image below
Screen Shot 2023-06-18 at 7 27 41 PM

@ermbrown
Copy link
Member

Updated!

@ermbrown
Copy link
Member

Completed. Ready for review.

@ermbrown ermbrown assigned anitadesigns and unassigned ermbrown Jun 19, 2023
@anitadesigns anitadesigns removed their assignment Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: design system issues relating to the general design system feature: figma wireframes priority: high role: design anything related to design size: 1pt can be done in 6 hours or less
Projects
P: EA: Project Board
Status: Done
Milestone
Systems / Foundations 1 - Design
Development

No branches or pull requests
3 participants
@phuonguvan @anitadesigns @ermbrown