Feature one click publish / Run Button Redesgin #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was
linked to
issues
Sep 11, 2024
JosiasAurel
requested changes
Sep 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋,
This PR addresses the following:
Feature Implementation (Ref: "New PR" button in Editor view for games #1743)
Introduced a new feature to publish games directly from the Sprig editor. After authorizing GitHub once, the process runs seamlessly in the background while you continue editing in the Sprig editor.
UI Fix for Run Menu (Ref: Combine 'Run' and 'Run on device' button #1971)
Redesigned the "Run" menu to align with the planned UI updates. The new design better integrates with the overall editor interface. (Feedback is welcome!)
Backend Updates
This PR also introduces several new environment variables to support the feature:
GITHUB_CLIENT_SECRETPUBLIC_GITHUB_CLIENT_IDPUBLIC_GITHUB_REDIRECT_URIPUBLIC_GALLERY_API(These are added to help future developers understand why these variables are needed 🕺)
Screenshots of the Implementation:
1. Publish Game from Editor:
2. Re-designed Run Button: